Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(semaphore): ensure holderKeys carry all information needed. Fixes #8684 #13553

Merged
merged 16 commits into from
Sep 18, 2024
Merged

fix(semaphore): ensure holderKeys carry all information needed. Fixes #8684 #13553

merged 16 commits into from
Sep 18, 2024
+499 −60

Commits on Sep 18, 2024

  1. fix: ensure Holding keys carry all information needed 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    74895c0 View commit details
    Browse the repository at this point in the history

  2. fix: added tests for edge cases 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    bd53d0f View commit details
    Browse the repository at this point in the history

  3. fix: lint issue addressed 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    335342a View commit details
    Browse the repository at this point in the history

  4. fix: addressed comments 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    193320e View commit details
    Browse the repository at this point in the history

  5. fix: address feedback 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7872148 View commit details
    Browse the repository at this point in the history

  6. fix: replace os.Setenv with t.Setenv 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    37a251c View commit details
    Browse the repository at this point in the history

  7. fix: added godoc comment 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    16d01e3 View commit details
    Browse the repository at this point in the history

  8. fix: remove v1 support 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2b21394 View commit details
    Browse the repository at this point in the history

  9. docs: reset envrionment variable docs 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c56d7ac View commit details
    Browse the repository at this point in the history

  10. fix: removed unnecessary v1 holder key check 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2fd00eb View commit details
    Browse the repository at this point in the history

  11. chore: general code cleanup for holding key changes 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    854907e View commit details
    Browse the repository at this point in the history

  12. chore: remove unnecessary import 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2771425 View commit details
    Browse the repository at this point in the history

  13. fix: add template level migration 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3e7a825 View commit details
    Browse the repository at this point in the history

  14. fix: check level first 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    94828e9 View commit details
    Browse the repository at this point in the history

  15. fix: address feedback 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6d4da2c View commit details
    Browse the repository at this point in the history

  16. fix: removed logging 

    Signed-off-by: isubasinghe <[email protected]>
    @isubasinghe
    isubasinghe committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e445525 View commit details
    Browse the repository at this point in the history