Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump docker from 26.1.5 to 27.1.1 #13524

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

shuangkun
Copy link
Member

Fix cve CVE-2024-41110 https://nvd.nist.gov/vuln/detail/CVE-2024-41110

Motivation

Modifications

Verification

@shuangkun shuangkun added the type/security Security related label Aug 28, 2024
@agilgur5 agilgur5 changed the title fix: CVE-2024-41110 in workflow-controller fix(deps): bump docker to 27.1.1 to fix CVE Aug 28, 2024
@agilgur5 agilgur5 changed the title fix(deps): bump docker to 27.1.1 to fix CVE fix(deps): bump docker from 26.1.5 to 27.1.1 to fix CVE Aug 28, 2024
Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix cve CVE-2024-41110 https://nvd.nist.gov/vuln/detail/CVE-2024-41110

Huh I thought this was already fixed in #13416 per #13416 (comment) (and one more patch version bump in #13446)

Dependabot and Snyk aren't currently alerting on it either.

Looking at the CVE, the current version we're on, 26.1.5, does contain the fix already. So moving to 27.1.1 doesn't add the fix, it's just a pure dep upgrade.

Also the CVE does not impact our usage, per my above linked comment

@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Aug 28, 2024
@agilgur5 agilgur5 changed the title fix(deps): bump docker from 26.1.5 to 27.1.1 to fix CVE chore(deps): bump docker from 26.1.5 to 27.1.1 Aug 28, 2024
@agilgur5 agilgur5 removed the type/security Security related label Aug 28, 2024
@shuangkun
Copy link
Member Author

shuangkun commented Aug 29, 2024

Oh, you are right.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you see the CVE alert? The latest Snyk build succeeds on master branch https://github.com/argoproj/argo-workflows/actions/runs/10612060725/job/29412929113

@agilgur5
Copy link
Contributor

agilgur5 commented Aug 30, 2024

The latest Snyk build succeeds on master branch

I wrote this above as well.

My guess is @shuangkun might have seen it in an image scan or something, because v3.5.10 has 26.1.4 as #13446 has yet to make it into a release.

This upgrade is still good to have I suppose, it's just not a dep CVE fix

@shuangkun
Copy link
Member Author

Where do you see the CVE alert? The latest Snyk build succeeds on master branch https://github.com/argoproj/argo-workflows/actions/runs/10612060725/job/29412929113

I see in 3.5.10 release.

@agilgur5
Copy link
Contributor

#13446 will be out in 3.5.11

Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as the update is good to have anyway, just not a dep CVE fix

@agilgur5 agilgur5 merged commit a35917e into argoproj:main Aug 31, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants