WIP: Add Task names to Pod names

[ian-howell]

• This proposal adds the name of each task to the name of the pod it is
  associated with. This makes it easier to keep track of which pod is
  performing which task.

Still a work in progress - unit tests are failing, and there's probably a better way to deal with parentheses.

This would close #1319 if it is accepted.

Let me know what you think :)

[sruon]

Probably need to check the size of the resulting name to ensure it is below 253 characters as well.

[ian-howell]

Good call. Name length is fixed in the last push.

[ian-howell]

Here's a before/after example of this feature:

Before

$ kubectl apply -f steps.yaml
NAME               READY     STATUS      RESTARTS   AGE
steps-1781811180   0/2       Completed   0          7s
steps-1832144037   0/2       Completed   0          7s
steps-215716891    0/2       Completed   0          11s

After

$ kubectl apply -f steps.yaml
NAME              READY     STATUS      RESTARTS   AGE
steps-0.hello1    0/2       Completed   0          12s
steps-1.hello2a   0/2       Completed   0          9s
steps-1.hello2b   0/2       Completed   0          9s

One notable side effect of this change is that the pods are always listed in step-order.

[AudriusButkevicius]

What is this blocked on? I think this is a great addition.
Furthermore, it would be nice to expose parameters in the workflow name, if you have parameterized workflows.

[ian-howell]

Hey @AudriusButkevicius, I honestly can't recall why I stopped working on this - it's definitely a more involved change than I at first thought it would be. I've rebased my branch, and I'll take another swing at it as soon as I find some time to do so.

[AudriusButkevicius]

I am happy to help out if its clear what the remaining work is, but it seems PRs on this project aren't getting that much attention.

[ian-howell]

@jessesuen @sarabala1979 I believe this is ready to review

[sarabala1979]

Can you keep the same naming convention? can you change the . to - in step name
steps-5l6mg-0.hello1-1579193971 to steps-5l6mg-0-hello1-1579193971

[ian-howell]

@sarabala1979 done.

[ian-howell]

@sarabala1979 could you take another look at this when you get a moment?

[sarabala1979]

LGTM. Resolve the conflicts

[ian-howell]

@sarabala1979 Conflicts are resolved.

Here's the message from the gate failure:

golangci-lint run --config golangci.yml                                                                                                                                                    
level=error msg="[runner] 0/12 linters finished: deadline exceeded"                                                                                                                        
level=error msg="Deadline exceeded: try increase it by passing --deadline option"                                                                                                          
Makefile:133: recipe for target 'lint' failed                                                                                                                                              
make: *** [lint] Error 4                                                                                                                                                                   

I'm not sure how to fix this one without increasing the deadline on the linter...

[alexec]

@ian-howell is this still wanted please?

[alexec]

Added wontfix label as this has no activity for 6 months.

[simster7]

Added wontfix label as this has no activity for 6 months.

Seems like this PR is done and even approved, it just was never merged. @ian-howell do you think you could resolve the conflicts?

[alexec]

@simster7 +1

[astanway]

Chiming in - this is a highly desired feature, and it has huge advantages for downstream metrics and monitoring, given podnames are a first class citizen in Grafana, GKE logs, Prometheus, Stackdriver, etc. I strongly support adding it and I hope to see it in a release

[BrookRoberts]

+1, if (as seems) this feature exists in an MR and is ready to go it would be a very useful and addition!

[fidel-perez]

+1. We really need this in our project. Is there any other way in Argo to change the name of the pods being started by templates?

[simster7]

I’ll take a look into this early next week

[vitalyrychkov]

Hi Simon, did you have a chance to have a look ever since? I was also looking for this feature.

[davidghiurco]

I need to add a +1 on this, since fine-grained pod monitoring with prometheus is impossible when all the pods in a workflow are named random jargon that does not differentiate what task they are performing.

[pc-kdholakia]

+1 on this, it will ease the monitoring process.

[alexec]

Better to thumbs-up the issue, not this closed PR.

[ghiander]

Hello, what happened with this? It's a very useful feature to have, I am struggling to configure Grafana to observe some specific steps without having their names in the pod names

[aaron-arellano]

this feature has causes a lot of upstream issues outside of Argo, particularly syncing of the kube downward API and etcd. I mentioned this in various open threads but pinging here so more engineers that worked on this feature are aware. This should be reverted until a real solution is created, not continuous patches.

#10107 #10267

[agilgur5]

Hello, what happened with this?

This was replaced by #6712.

This should be reverted until a real solution is created, not continuous patches.

This PR was never merged, see #6712, which can be turned off by setting POD_NAMES=v1. The eventual plan seems to be to replace with #10267.