Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): upgrade argo-ui for visible filter dropdown bar arrow. Fixes #7789 #13169

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Jun 12, 2024

Fixes #7789

Motivation

Dropdown arrow was half hidden, and we want to fix it to improve the visual
Screen Shot 2022-02-07 at 1 26 38 PM

Modifications

Upgrade to latest version of argo-ui components

Verification

build success
arrow visible
functioning normal


image


image

@tczhao tczhao marked this pull request as ready for review June 12, 2024 03:35
@tczhao tczhao requested a review from agilgur5 June 12, 2024 03:36
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies area/ui javascript Pull requests that update Javascript dependencies labels Jun 12, 2024
@agilgur5 agilgur5 self-assigned this Jun 14, 2024
@agilgur5 agilgur5 linked an issue Jun 14, 2024 that may be closed by this pull request
4 tasks
@agilgur5 agilgur5 changed the title fix(ui): visible filter dropdown bar arrow. Fixes #7789 fix(ui): upgrade argo-ui for visible filter dropdown bar arrow. Fixes #7789 Jun 14, 2024
Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare view LGTM -- a few other fixes and dep removals included too

@agilgur5 agilgur5 enabled auto-merge (squash) June 14, 2024 06:56
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Jun 14, 2024
@agilgur5 agilgur5 merged commit dc6a18d into main Jun 14, 2024
17 checks passed
@agilgur5 agilgur5 deleted the 7789-fix-dropdown-arrow branch June 14, 2024 07:04
@agilgur5 agilgur5 removed this from the v3.5.x patches milestone Jun 17, 2024
@agilgur5
Copy link
Contributor

Dang, I wasn't able to backport this to release-3.5 as it merge conflicted quite heavily. Specifically, it's missing #12516 (and #12163). We may want to backport those as well, TBD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
2 participants