build(cli): add riscv64 support#12977
Merged
agilgur5 merged 1 commit intoargoproj:mainfrom Apr 24, 2024
Merged
Conversation
Member
|
This will only support the CLI on riscV, but that's the only component we support on non amd64/arm64 for other less popular architectures. |
Joibel
approved these changes
Apr 24, 2024
Member
|
@mengzhuo, you will need to sign your commits according to https://github.com/argoproj/argoproj/blob/main/community/CONTRIBUTING.md. You will need to rewrite this commit to make the DCO check pass. |
Signed-off-by: Meng Zhuo <mengzhuo1203@gmail.com>
^This, see also #12067 for the rest |
agilgur5
approved these changes
Apr 24, 2024
agilgur5
left a comment
There was a problem hiding this comment.
LGTM. There is existing precedent for CLI binaries, as Alan noted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As riscv growing popularity and being adopted by more projects
https://github.com/carlosedp/riscv-bringup
and commercial Cloud provider like Scaleway https://www.scaleway.com/en/news/scaleway-launches-its-risc-v-servers-in-the-cloud-a-world-first-and-a-firm-commitment-to-technological-independence/
It's possible to run argo workflow by riscv users.
Modifications
Adds riscv64 support
Verification
argo prints help verbose.