feat: allow lastRetry variables in expressions

[eduardodbr]

Fixes #10364

Motivation

Modifications

Verification

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: pod-spec-patch
spec:
  entrypoint: whalesay
  templates:
  - name: whalesay
    retryStrategy:
      limit: 5
      retryPolicy: Always
    podSpecPatch: '{"containers":[{"name":"main", "resources":{"requests":{"memory": "{{=(sprig.int(lastRetry.exitCode)==1 ? int(retries) : 1)* 10}}Mi" }}}]}'
    container:
      image: python:alpine3.6
      command: ["python", -c]
      args: ["import sys; sys.exit(1)"]

uses the exit code to know when to increase memory. This should use 10MB,20MB,30MB,40MB,50MB in each iteration

[juliev0]

Since this function is already so long, can we separate this new logic into a function to build the local scope from lastChildNode?

[juliev0]

Ignore this comment if this comment ends up making more sense

[tczhao]

we could use the output from buildRetryStrategyLocalScope,
and add them in localParams

[juliev0]

Since we're already using LocalVarRetries in this scope, it does seem reasonable to me to use these other variables in the general template scope as well.

[juliev0]

Actually, I haven't looked at it long enough, but I am kind of wondering if there's a way to do this and not have to be setting these same variables twice. Should processNodeRetries() possibly take a localScope and then be able to modify it and return it to the caller? You have probably looked at the code longer than I have - what do you think?

[tczhao]

we could use the output from buildRetryStrategyLocalScope,
and add them in localParams

[tczhao]

👍

[gdhagger]

This PR seems to have stalled - would love to be able to use these vars, what needs to happen to get it moving again?

[eduardodbr]

this was done more than a year ago. I would need to review everything which will take time. If anyone wants to jump in and contribute the requested changes I'm ok with that.

[isubasinghe]

resurrected the PR here: #14450

[caelan-io]

Thank you for contributing this, @eduardodbr ! Isitha picked it up and rounded it out to merge the feature in #14450 and it's released in v3.7, so we'll close this PR out. cc @gdhagger and @EladProject for visibility.