chore(deps): upgrade swagger-ui-react to v5
#12540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- v4 is no longer supported, so we should get onto the latest major, v5 - with the current build system and the current version of `swagger-ui-react`, we can now update to v5 without errors - previously this had issues with older Webpack and older Babel, as well as loaded the Node bundle instead of the browser bundle Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
added
type/dependencies
terrytangyuan
approved these changes
Jan 18, 2024
7 tasks
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
This was referenced May 26, 2024
fix(deps): upgrade swagger-ui-react v5.17.3, react-dom v18.3.1, and react v18.3.1. Fixes CVEs
#13069
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes / Closes #12273
Follow-up to #11418 (comment), #11640 (comment), #12058
swagger-ui-reactMotivation
v4 is no longer supported, so we should get onto the latest major, v5. v5 is also more performant, c.f. #12518 which updates Swagger UI for the docs and details that a bit more
swagger-ui-react, we can now update to v5 without errorsNOTE: I did not update to v5.11.0 as that has a breaking change that is not compatible with our current version of React: swagger-api/swagger-ui#9495
Modifications
Upgrade
swagger-ui-reactfrom latest v4 to v5.10.0Verification
Loaded the
/apidocspage and confirmed it was working: