refactor(ui): use import type syntax where possible
#12514
Conversation
- now that we've migrated from archived `tslint` to `eslint` and updated `prettier` from v1 to v3, we can _finally_ use this newer TS syntax
- this fixes a few warnings in the build as well as makes things more explicit and efficient
- note: there are more warnings to fix around `export type`, but those are all from `argo-ui` and so can't be fixed from within this repo
Signed-off-by: Anton Gilgur <[email protected]>
because it fixes existing warnings. those warnings also become errors in #12516 could potentially word it as a |
agilgur5
changed the title
import type syntax where possibleimport type syntax where possible
|
How would you feel about being assignee on this @terrytangyuan ? Given that it's a "prioritized-review", and has been for over a week, it needs an Assignee. I don't think I have the right background for this. But I see it already has 2 approvals. It also looks like this other prioritized-review PR is ready but blocked on this one. |
|
I have a concern on these small refactor PRs. Started discussion on Slack https://cloud-native.slack.com/archives/C0510EUH90V/p1706279158785129 |
Splitting out a new repo is a future-facing question, that historically has taken months+ to occur (the SDKs being a current example of that) and requires org-level permissions that few people have. A new repo requires even more time and will require splitting the |
|
@isubasinghe Are you comfortable merging this since you've given approval? |
|
@juliev0 I am comfortable merging this, but I don't have write access yet I think? |
|
Got it! Okay, should be soon.On Feb 2, 2024, at 6:53 PM, Isitha Subasinghe ***@***.***> wrote:
@juliev0 I am comfortable merging this, but I don't have write access yet I think?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Crenshaw said he'd get to membership etc updates on Monday, for reference |
|
I’ll add once it’s publicly announced |
Signed-off-by: Anton Gilgur <[email protected]>
Unblocks #12516
Follow-up to #12163 & #12290, which unblocked this
Follow-up to #12150 (comment)
Same changes can be made for #12158 and the
argo-uiwarnings introduced in #12061Motivation
tslinttoeslintand updatedprettierfrom v1 to v3, we can finally use this newer TS syntax from TS 3.8export type, but those are all fromargo-ui's source code and so can't be fixed from within this repoModifications
import typesyntax in a few files where it is only types that are importedVerification
yarn buildworks fine, with a few less warnings nowmake start UI=trueand tested UI, esp.monaco-editor-- all still works fine