Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ArtifactGC Fails for Stopped Workflows. Fixes #11879 #11947

Merged
merged 38 commits into from
Nov 13, 2023
Merged

fix: ArtifactGC Fails for Stopped Workflows. Fixes #11879 #11947

merged 38 commits into from
Nov 13, 2023

Commits on Sep 29, 2023

  1. test: Add failing e2e test for stopped DAG workflow ArtifactGC. Towards 

    argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    4226bc3 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. test: Improve robustness of stopped DAG workflow ArtifactGC test. Tow… 

    …ards argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    4fee946 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. test: Move task reconciliation in operator.go to before garbage colle… 

    …ction to ensure that stopped workflow artifacts are garbage collected. Remove bug in e2e testing WaitForWorkflow() timeout option in when.go. Improve robustness of TestStoppedWorkflow e2e test. Fixes argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    4ffeb5f View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Merge branch 'master' into fix/artifactgc_stopped_workflow

    @Garett-MacGowan
    Garett-MacGowan authored Oct 7, 2023
    Configuration menu
    Copy the full SHA
    59b2e80 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. test: Add new E2E_WAIT_TIMEOUT_BIAS environment varible to enable a b… 

    …ias for test timeouts in slow environments. Adjust WaitForWorkflow timeout parameter in retry_test.go (added 30 seconds) to be in line with the previously defined timeout before fixing the WaitForWorkflow custom timeout logic in commit 4ffeb5f. Fixes argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a0aa696 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. test: Minor refactors to TestStoppedWorkflow ArtifactGC test. Fixes a… 

    …rgoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b328314 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. test: Adjust TestStoppedWorkflow test to prevent potential unwanted w… 

    …orkflow deletions during testing (in case tests are running in parallel). Fixes argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    50cadb6 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. fix: Add new WorkflowTaskResult label to prevent race condition in Ar… 

    …tifactGC. Fixes argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    07fec09 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. test: Fix ArtifactGC tests. Add tests for refactor. Fixes argoproj#11879 

    

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    5d267c9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/artifactgc_stopped_workflow

    @Garett-MacGowan
    Garett-MacGowan authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    edb8ed6 View commit details
    Browse the repository at this point in the history

  3. test: Add 30s to WaitForWorkflow timeouts to account for WaitForWorkf… 

    …low rework. Fixes argoproj#11947

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    f9e026a View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. fix: Add state to ArtGCStatus to keep track of completed task results… 

    …. Towards argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    5ed2ed9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/artifactgc_stopped_workflow 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    29e8b29 View commit details
    Browse the repository at this point in the history

  3. fix: Undo context rework in wait container since it did not have the … 

    …desired effect. Towards argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d37e911 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. fix: Move TaskResultsCompleted from ArtGCStatus to WorkflowStatus. Si… 

    …mplify LabelKeyReportOutputsCompleted label setting logic. Add support for legacy/insecure pod patch for ReportOutputsCompleted annotation/label. Towards argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    02b58a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. fix: Refactors to address PR comments. Add context.Background() to wa… 

    …it container defer methods to ensure they complete. Fixes argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7b058ca View commit details
    Browse the repository at this point in the history

  2. test: Fix ReportOutputs test. Fixes argoproj#11879 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    65bd7dd View commit details
    Browse the repository at this point in the history

  3. fix: fix typo. Towards argoproj#11974 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    db7b4e0 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Merge branch 'master' into fix/artifactgc_stopped_workflow

    @Garett-MacGowan
    Garett-MacGowan authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f7a3a82 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/artifactgc_stopped_workflow

    @Garett-MacGowan
    Garett-MacGowan authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    025c22c View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. fix: Bug fix for marking task result complete in context of legacy/in… 

    …secure pod patch. Fixes argoproj#11974

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    df91580 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/artifactgc_stopped_workflow' of github.com:GarettSo… 

    …ftware/argo-workflows into fix/artifactgc_stopped_workflow

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5398870 View commit details
    Browse the repository at this point in the history

  3. fix: return error from AddAnnotation for AnnotationKeyReportOutputsCo… 

    …mpleted. Fixes argoproj#11974

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ff69ba3 View commit details
    Browse the repository at this point in the history

  4. test: Add 30 seconds or more to WaitForWorkflow timeout to account fo… 

    …r change caused by prior bug fix. Towards argoproj#11974

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    948444d View commit details
    Browse the repository at this point in the history

  5. test: Add 30 seconds or more to WaitForWorkflow timeout to account fo… 

    …r change caused by prior bug fix. Towards argoproj#11974

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    97af87a View commit details
    Browse the repository at this point in the history

  6. fix: Run linter. Towards argoproj#11879 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f7022a3 View commit details
    Browse the repository at this point in the history

  7. test: Make TestMetricGC more robust. Towards argoproj#11879 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ff0adc5 View commit details
    Browse the repository at this point in the history

  8. test: rerun tests. Towards argoproj#11879 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1eedcf1 View commit details
    Browse the repository at this point in the history

  9. test: rerun tests. Towards argoproj#11879 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a78e413 View commit details
    Browse the repository at this point in the history

  10. fix: Move ArtifactGC to before workflow level synchronization lock. T… 

    …owards argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5168734 View commit details
    Browse the repository at this point in the history

  11. test: rerun tests. Towards argoproj#11879 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    95aa027 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into fix/artifactgc_stopped_workflow

    @Garett-MacGowan
    Garett-MacGowan authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    6564221 View commit details
    Browse the repository at this point in the history

  13. test: rerun tests. Towards argoproj#11879 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f5af96d View commit details
    Browse the repository at this point in the history

  14. fix: merge master. Towards argoproj#11879 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    bf3a4e7 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. fix: Make signaled container set test more robust. Prevent premature … 

    …deletion of task results. Change owner reference for task result to Workflow. Add artifactgc test for stopped workflow with pod gc on pod completion. Fixes argoproj#11879

Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    6da8567 View commit details
    Browse the repository at this point in the history

  2. test: Fix signals test. comment & logging tweaks 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    941bab0 View commit details
    Browse the repository at this point in the history

  3. test: Fix ordering of assert.contains in signals test 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    c5cb204 View commit details
    Browse the repository at this point in the history

  4. test: empty commit for ci re-submit. 

    Signed-off-by: Garett MacGowan <[email protected]>
    @Garett-MacGowan
    Garett-MacGowan committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    b35c058 View commit details
    Browse the repository at this point in the history