Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect minio chart changes in documentation #1147

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Reflect minio chart changes in documentation #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ARTIFACT_REPO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ $ helm install stable/minio --name argo-artifacts --set service.type=LoadBalance

Login to the Minio UI using a web browser (port 9000) after obtaining the external IP using `kubectl`.
```
$ kubectl get service argo-artifacts-minio
$ kubectl get service argo-artifacts
```

On Minikube:
```
$ minikube service --url argo-artifacts-minio
$ minikube service --url argo-artifacts
```

NOTE: When minio is installed via Helm, it uses the following hard-wired default credentials,
Expand Down
16 changes: 8 additions & 8 deletions demo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@ helm install stable/minio --name argo-artifacts --set service.type=LoadBalancer

Login to the Minio UI using a web browser (port 9000) after exposing obtaining the external IP using `kubectl`.
```
kubectl get service argo-artifacts-minio -o wide
kubectl get service argo-artifacts -o wide
```
On Minikube:
```
minikube service --url argo-artifacts-minio
minikube service --url argo-artifacts
```

NOTE: When minio is installed via Helm, it uses the following hard-wired default credentials,
Expand All @@ -98,8 +98,8 @@ Create a bucket named `my-bucket` from the Minio UI.

## 6. Reconfigure the workflow controller to use the Minio artifact repository

Edit the workflow-controller config map to reference the service name (argo-artifacts-minio) and
secret (argo-artifacts-minio) created by the helm install:
Edit the workflow-controller config map to reference the service name (argo-artifacts) and
secret (argo-artifacts) created by the helm install:
```
kubectl edit cm -n argo workflow-controller-configmap
...
Expand All @@ -108,18 +108,18 @@ data:
artifactRepository:
s3:
bucket: my-bucket
endpoint: argo-artifacts-minio.default:9000
endpoint: argo-artifacts.default:9000
insecure: true
# accessKeySecret and secretKeySecret are secret selectors.
# It references the k8s secret named 'argo-artifacts-minio'
# It references the k8s secret named 'argo-artifacts'
# which was created during the minio helm install. The keys,
# 'accesskey' and 'secretkey', inside that secret are where the
# actual minio credentials are stored.
accessKeySecret:
name: argo-artifacts-minio
name: argo-artifacts
key: accesskey
secretKeySecret:
name: argo-artifacts-minio
name: argo-artifacts
key: secretkey
```

Expand Down