Skip to content

fix: Update Bitbucket SSH host key#11091

Merged
terrytangyuan merged 1 commit intoargoproj:masterfrom
toredash:fix/bitbucket-ssh-keys
May 16, 2023
Merged

fix: Update Bitbucket SSH host key#11091
terrytangyuan merged 1 commit intoargoproj:masterfrom
toredash:fix/bitbucket-ssh-keys

Conversation

@toredash
Copy link
Copy Markdown
Contributor

@toredash toredash force-pushed the fix/bitbucket-ssh-keys branch from 7d4ea13 to 0e4f433 Compare May 16, 2023 07:52
Signed-off-by: Tore S. Loenoey <tore.lonoy@gmail.com>
@toredash toredash force-pushed the fix/bitbucket-ssh-keys branch from 0e4f433 to 42ebe66 Compare May 16, 2023 08:32
@toredash
Copy link
Copy Markdown
Contributor Author

related;

Had an issue where cloning resulted in:

level=fatal msg="artifact bitbucket-repository failed to load: failed to clone \"git@bitbucket.org:X/X.git\": ssh: handshake failed: knownhosts: key mismatch"

This started to occur after bitbucket added their keys as of 15th of May (blogpost). This would not happen if go-git was upgraded to >=5.5.0, as it includes a fix described here (go-git/go-git#411)

I'm not sure why the go-git module is forked in argo-workflow (

replace github.com/go-git/go-git/v5 => github.com/argoproj-labs/go-git/v5 v5.4.7
), but argo-cd uses the upstream version of go-git (argoproj/argo-cd#11893). They have had similar problems (https://github.com/argoproj/argo-cd/issues/7723)[](url)

@terrytangyuan terrytangyuan enabled auto-merge (squash) May 16, 2023 17:37
@terrytangyuan
Copy link
Copy Markdown
Member

Thank you. For anyone else having the issue, the workaround is to mount the updated host keys in /etc/ssh/

@terrytangyuan terrytangyuan merged commit 019705e into argoproj:master May 16, 2023
@terrytangyuan
Copy link
Copy Markdown
Member

related;

Had an issue where cloning resulted in:

level=fatal msg="artifact bitbucket-repository failed to load: failed to clone \"git@bitbucket.org:X/X.git\": ssh: handshake failed: knownhosts: key mismatch"

This started to occur after bitbucket added their keys as of 15th of May (blogpost). This would not happen if go-git was upgraded to >=5.5.0, as it includes a fix described here (go-git/go-git#411)

I'm not sure why the go-git module is forked in argo-workflow (

replace github.com/go-git/go-git/v5 => github.com/argoproj-labs/go-git/v5 v5.4.7

), but argo-cd uses the upstream version of go-git (argoproj/argo-cd#11893). They have had similar problems ([https://github.com/argoproj/argo-cd/issues/7723)

Thanks. Let's track this in #10091

woehrl01 pushed a commit to woehrl01/argo-workflows that referenced this pull request May 17, 2023
Signed-off-by: Tore S. Loenoey <tore.lonoy@gmail.com>
Co-authored-by: Tore S. Loenoey <torestendal.lonoy@tv2.no>
terrytangyuan pushed a commit that referenced this pull request May 25, 2023
Signed-off-by: Tore S. Loenoey <tore.lonoy@gmail.com>
Co-authored-by: Tore S. Loenoey <torestendal.lonoy@tv2.no>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
Signed-off-by: Tore S. Loenoey <tore.lonoy@gmail.com>
Co-authored-by: Tore S. Loenoey <torestendal.lonoy@tv2.no>
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
Signed-off-by: Tore S. Loenoey <tore.lonoy@gmail.com>
Co-authored-by: Tore S. Loenoey <torestendal.lonoy@tv2.no>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/artifacts S3/GCP/OSS/Git/HDFS etc solution/workaround There's a workaround, might not be great, but exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants