Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long container args and/or script source overflows in UI #8916

Closed
3 tasks done
dakotalillie opened this issue Jun 5, 2022 · 0 comments · Fixed by #8947
Closed
3 tasks done

Long container args and/or script source overflows in UI #8916

dakotalillie opened this issue Jun 5, 2022 · 0 comments · Fixed by #8947

Comments

@dakotalillie
Copy link
Contributor

Checklist

  • Double-checked my configuration.
  • Tested using the latest version.
  • Used the Emissary executor.

Summary

Providing a lengthy argument to a container template, or a lengthy source to a script template, causes the provided argument/source to visually overflow in the UI.

I have observed this issue in multiple versions, including:

  • v3.3.6
  • "latest" (master branch)

Diagnostics

Here are two YAML examples which can be used to reproduce this issue, along with screenshots of the UI for each:

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: example-
spec:
  entrypoint: example
  templates:
  - name: example
    container:
      image: ubuntu:latest
      command: [bash]
      args:
        - -c
        - |-
          # The exact contents of this script don't matter.
          # All that matters for this example is that the line is sufficiently long.
          if [ "$EXAMPLE_ENV_VAR" == "hello darkness my old friend" ]; then
            echo "Hello world!"
          fi

Screen Shot 2022-06-04 at 6 12 40 PM

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: example-
spec:
  entrypoint: example
  templates:
  - name: example
    script:
      image: ubuntu:latest
      command: [bash]
      source: |-
        # The exact contents of this script don't matter.
        # All that matters for this example is that the line is sufficiently long.
        if [ "$EXAMPLE_ENV_VAR" == "hello darkness my old friend" ]; then
          echo "Hello world!"
        fi

Screen Shot 2022-06-04 at 6 14 00 PM

It looks like a similar issue was addressed in #7876. Adopting the same fix for this should be straightforward. However, I wanted to check first to see whether an alternative solution might be preferable, such as using a scrollbar. Here's what two potential solutions might look like:

Screen Shot 2022-06-04 at 6 21 23 PM

Screen.Recording.2022-06-04.at.6.25.27.PM.mov

Either way, I'm happy to submit a PR.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants