Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support session tokens to access S3 buckets #5446

Closed
arl7 opened this issue Mar 18, 2021 · 5 comments · Fixed by #12467
Closed

Support session tokens to access S3 buckets #5446

arl7 opened this issue Mar 18, 2021 · 5 comments · Fixed by #12467
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc type/feature Feature request

Comments

@arl7
Copy link

arl7 commented Mar 18, 2021

Summary

Argo-workflows should support session token in addition to access key and secret access key to access a bucket.

This issue was already raised some time back: #1749 but it got closed because of no response from the original poster of the request.

What change needs making?

Use Cases

When would you use this?
This is usefule in the case when users have access to only temporary credentials instead of permanent ones.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@arl7 arl7 added the type/feature Feature request label Mar 18, 2021
@alexec
Copy link
Contributor

alexec commented Mar 18, 2021

Would you like to submit a PR to add this?

@arl7
Copy link
Author

arl7 commented Mar 22, 2021

Sorry for late reply. Still working on this

@JacobHenner
Copy link

Linking duplicate: #1039

For reference, a similar feature was added to Argo Events in August: https://github.com/argoproj/argo-events/pull/2092/files

@arl7 are you still working on this? If not, I'd be interested in giving it a shot.

@hittingray
Copy link
Contributor

Hey @JacobHenner and @arl7, are either of you working on this? I just had a quick stab today and it doesn't seem too difficult. If neither of you are, I'll get around to a PR sometime soon.

@JacobHenner
Copy link

JacobHenner commented Dec 27, 2023

No, go ahead 🙂

hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Jan 5, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Jan 5, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Jan 5, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Jan 5, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Jan 8, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Jan 8, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Aug 28, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Aug 28, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Aug 28, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Aug 30, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Sep 5, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Sep 5, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Sep 5, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Sep 5, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Sep 5, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Sep 10, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Sep 10, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Sep 10, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Sep 11, 2024
hittingray added a commit to atlassian-forks/argo-workflows that referenced this issue Sep 11, 2024
agilgur5 added a commit that referenced this issue Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants