Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc-ttl dose not work #1004

Closed
ghost opened this issue Sep 14, 2018 · 2 comments
Closed

gc-ttl dose not work #1004

ghost opened this issue Sep 14, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Sep 14, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

What happened: I submit the gcc-ttl.yaml , but after the workflow finished, it did not delete the workflow and pods

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Argo version: v2.2.0
@ywskycn
Copy link
Contributor

ywskycn commented Sep 21, 2018

Same to me. After checking the workflow-controller log, it shows
E0921 18:21:51.030059 1 ttlcontroller.go:124] error deleting 'default/gc-ttl-5mgg4': workflows.argoproj.io "gc-ttl-5mgg4" is forbidden: User "system:serviceaccount:argo:argo" cannot delete workflows.argoproj.io in the namespace "default".

@jessesuen so here we need to do another rolebinding?

@jessesuen
Copy link
Member

Oops, yes the role needs to be expanded to perform delete:

- apiGroups:
  - argoproj.io
  resources:
  - workflows
  - workflows/finalizers
  verbs:
  - get
  - list
  - watch
  - update
  - patch
  - delete # <<<< this needs to be added

icecoffee531 pushed a commit to icecoffee531/argo-workflows that referenced this issue Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants