feat: make submit workflow parameter form as textarea to input multi …

…line string easily (#7768) Signed-off-by: krrrr38 <[email protected]>
argoproj · Feb 7, 2022 · fb73d01 · fb73d01
1 parent 427394b
commit fb73d01
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/...plates/components/cluster-workflow-template-details/cluster-workflow-template-details.tsx b/...plates/components/cluster-workflow-template-details/cluster-workflow-template-details.tsx
@@ -123,7 +123,7 @@ export const ClusterWorkflowTemplateDetails = ({history, location, match}: Route
                 )}
             </>
             {template && (
-                <SlidingPanel isShown={!!sidePanel} onClose={() => setSidePanel(null)} isNarrow={true}>
+                <SlidingPanel isShown={!!sidePanel} onClose={() => setSidePanel(null)} isMiddle={true}>
                     <SubmitWorkflowPanel
                         kind='ClusterWorkflowTemplate'
                         namespace={namespace}

diff --git a/...app/workflow-templates/components/workflow-template-details/workflow-template-details.tsx b/...app/workflow-templates/components/workflow-template-details/workflow-template-details.tsx
@@ -120,7 +120,7 @@ export const WorkflowTemplateDetails = ({history, location, match}: RouteCompone
                 {!template ? <Loading /> : <WorkflowTemplateEditor template={template} onChange={setTemplate} onError={setError} onTabSelected={setTab} selectedTabKey={tab} />}
             </>
             {template && (
-                <SlidingPanel isShown={!!sidePanel} onClose={() => setSidePanel(null)} isNarrow={sidePanel === 'submit'}>
+                <SlidingPanel isShown={!!sidePanel} onClose={() => setSidePanel(null)} isMiddle={sidePanel === 'submit'}>
                     {sidePanel === 'submit' && (
                         <SubmitWorkflowPanel
                             kind='WorkflowTemplate'

diff --git a/ui/src/app/workflows/components/submit-workflow-panel.tsx b/ui/src/app/workflows/components/submit-workflow-panel.tsx
@@ -147,7 +147,7 @@ export class SubmitWorkflowPanel extends React.Component<Props, State> {
 
     private displayInputFieldForSingleValue(parameter: Parameter) {
         return (
-            <input
+            <textarea
                 className='argo-field'
                 value={this.getValue(parameter)}
                 onChange={event => {

diff --git a/ui/src/app/workflows/components/workflow-node-info/workflow-node-info.tsx b/ui/src/app/workflows/components/workflow-node-info/workflow-node-info.tsx
@@ -69,7 +69,9 @@ interface Props {
 const AttributeRow = (attr: {title: string; value: any}) => (
     <div className='row white-box__details-row' key={attr.title}>
         <div className='columns small-4'>{attr.title}</div>
-        <div className='columns columns--narrower-height small-8'>{attr.value}</div>
+        <div className='columns columns--narrower-height small-8' style={{whiteSpace: 'pre'}}>
+            {attr.value}
+        </div>
     </div>
 );
 const AttributeRows = (props: {attributes: {title: string; value: any}[]}) => (