Allow Makefile variables to be set from the command line (#1501)

This changes the assignment operator of various Makefile variables from
the recursive expansion operator (=) to the conditional assignment
operator (?=), such that a developer can define their own values for
those variables. This is highly valuable for a dev who wants to do local
development with a local docker image

Makefile

@@ -1,21 +1,21 @@
-PACKAGE=github.com/argoproj/argo
-CURRENT_DIR=$(shell pwd)
-DIST_DIR=${CURRENT_DIR}/dist
-ARGO_CLI_NAME=argo
+PACKAGE                = github.com/argoproj/argo
+CURRENT_DIR            = $(shell pwd)
+DIST_DIR               = ${CURRENT_DIR}/dist
+ARGO_CLI_NAME          = argo
 
-VERSION=$(shell cat ${CURRENT_DIR}/VERSION)
-BUILD_DATE=$(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
-GIT_COMMIT=$(shell git rev-parse HEAD)
-GIT_TAG=$(shell if [ -z "`git status --porcelain`" ]; then git describe --exact-match --tags HEAD 2>/dev/null; fi)
-GIT_TREE_STATE=$(shell if [ -z "`git status --porcelain`" ]; then echo "clean" ; else echo "dirty"; fi)
+VERSION                = $(shell cat ${CURRENT_DIR}/VERSION)
+BUILD_DATE             = $(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
+GIT_COMMIT             = $(shell git rev-parse HEAD)
+GIT_TAG                = $(shell if [ -z "`git status --porcelain`" ]; then git describe --exact-match --tags HEAD 2>/dev/null; fi)
+GIT_TREE_STATE         = $(shell if [ -z "`git status --porcelain`" ]; then echo "clean" ; else echo "dirty"; fi)
 
 # docker image publishing options
-DOCKER_PUSH=false
-IMAGE_TAG=latest
+DOCKER_PUSH           ?= false
+IMAGE_TAG             ?= latest
 # perform static compilation
-STATIC_BUILD=true
+STATIC_BUILD          ?= true
 # build development images
-DEV_IMAGE=false
+DEV_IMAGE             ?= false
 
 GOLANGCI_EXISTS := $(shell command -v golangci-lint 2> /dev/null)
 
@@ -30,7 +30,7 @@ override LDFLAGS += -extldflags "-static"
 endif
 
 ifneq (${GIT_TAG},)
-IMAGE_TAG=${GIT_TAG}
+IMAGE_TAG = ${GIT_TAG}
 override LDFLAGS += -X ${PACKAGE}.gitTag=${GIT_TAG}
 endif
 
@@ -41,7 +41,7 @@ endif
 endif
 
 ifdef IMAGE_NAMESPACE
-IMAGE_PREFIX=${IMAGE_NAMESPACE}/
+IMAGE_PREFIX = ${IMAGE_NAMESPACE}/
 endif
 
 # Build the project