Fix #1340 parameter substitution bug

Signed-off-by: Ilias Katsakioris <[email protected]>
argoproj · Apr 27, 2019 · e9f2a46 · e9f2a46
1 parent 4e37a44
commit e9f2a46
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/workflow/controller/workflowpod.go b/workflow/controller/workflowpod.go
@@ -185,7 +185,10 @@ func (woc *wfOperationCtx) createWorkflowPod(nodeName string, mainCtr apiv1.Cont
 	// Perform one last variable substitution here. Some variables come from the from workflow
 	// configmap (e.g. archive location) or volumes attribute, and were not substituted
 	// in executeTemplate.
-	podParams := woc.globalParams
+	podParams := make(map[string]string)
+	for gkey, gval := range woc.globalParams {
+		podParams[gkey] = gval
+	}
 	for _, inParam := range tmpl.Inputs.Parameters {
 		podParams["inputs.parameters."+inParam.Name] = *inParam.Value
 	}