fix: Invalid memory address or nil pointer dereference (#9409)

Signed-off-by: Saravanan Balasubramanian <[email protected]> Signed-off-by: Saravanan Balasubramanian <[email protected]>
argoproj · Aug 22, 2022 · 6f19e50 · 6f19e50
1 parent 7d9319b
commit 6f19e50
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/workflow/controller/operator.go b/workflow/controller/operator.go
@@ -1944,13 +1944,14 @@ func (woc *wfOperationCtx) executeTemplate(ctx context.Context, nodeName string,
 		}
 	}
 
-	node = woc.wf.GetNodeByName(node.Name)
-	if node == nil {
+	retrieveNode := woc.wf.GetNodeByName(node.Name)
+	if retrieveNode == nil {
 		err := fmt.Errorf("no Node found by the name of %s;  wf.Status.Nodes=%+v", node.Name, woc.wf.Status.Nodes)
 		woc.log.Error(err)
 		woc.markWorkflowError(ctx, err)
 		return node, err
 	}
+	node = retrieveNode
 
 	// Swap the node back to retry node
 	if retryNodeName != "" {