fix: Treat 'connection reset by peer' as a transient network error. F…

…ixes #9013 (#9017) Treat 'connection reset by peer' as a transient network error, Fixes #9013 Signed-off-by: Mike Tougeron <[email protected]>
argoproj · Jun 21, 2022 · 6228748 · 6228748
1 parent cd43d01
commit 6228748
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/util/errors/errors.go b/util/errors/errors.go
@@ -80,6 +80,9 @@ func isTransientNetworkErr(err error) bool {
 	} else if strings.Contains(errorString, "connection timed out") {
 		// If err is a net.Dial timeout, retry.
 		return true
+	} else if strings.Contains(errorString, "connection reset by peer") {
+		// If err is a ECONNRESET, retry.
+		return true
 	}
 
 	return false

diff --git a/util/errors/errors_test.go b/util/errors/errors_test.go
@@ -23,6 +23,7 @@ var (
 	tlsHandshakeTimeoutErr net.Error = netError("net/http: TLS handshake timeout")
 	ioTimeoutErr           net.Error = netError("i/o timeout")
 	connectionTimedout     net.Error = netError("connection timed out")
+	connectionReset        net.Error = netError("connection reset by peer")
 	transientErr           net.Error = netError("this error is transient")
 	transientExitErr                 = exec.ExitError{
 		ProcessState: &os.ProcessState{},
@@ -69,6 +70,9 @@ func TestIsTransientErr(t *testing.T) {
 	t.Run("ConnectionTimeout", func(t *testing.T) {
 		assert.True(t, IsTransientErr(connectionTimedout))
 	})
+	t.Run("ConnectionReset", func(t *testing.T) {
+		assert.True(t, IsTransientErr(connectionReset))
+	})
 	t.Run("TransientErrorPattern", func(t *testing.T) {
 		_ = os.Setenv(transientEnvVarKey, "this error is transient")
 		assert.True(t, IsTransientErr(transientErr))