Skip to content

Commit

Permalink
Fix output artifact and parameter conflict (#1125)
Browse files Browse the repository at this point in the history
`SaveArtifacts` deletes the files that `SaveParameters` might still need, so we're calling `SaveParameters` first.
Fixes #1124
  • Loading branch information
Ark-kun authored and alexmt committed Dec 14, 2018
1 parent 6bb3adb commit 587ab1a
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions cmd/argoexec/commands/wait.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,14 @@ func waitContainer() error {
wfExecutor.AddError(err)
return err
}
err = wfExecutor.SaveArtifacts()
// Saving output parameters
err = wfExecutor.SaveParameters()
if err != nil {
wfExecutor.AddError(err)
return err
}
// Saving output parameters
err = wfExecutor.SaveParameters()
// Saving output artifacts
err = wfExecutor.SaveArtifacts()
if err != nil {
wfExecutor.AddError(err)
return err
Expand Down

0 comments on commit 587ab1a

Please sign in to comment.