Issue#1165 fake outputs don't notify and task completes successfully (#…

…1247)

* Issue#1165 fake outputs don't notify and task completes successfully

This PR is addressing the Issue#1165 reported by @alexfrieden.

Issue/Bug: Argo is finishing the task successfully even artifact /file does exist.

Fix: Validate the created gzip contains artifact or file. if file/artifact doesn't exist, Current step/stage/task will be failed with log message .

Sample Log:
'''
INFO[0029] Updating node artifact-passing-lkvj8[0].generate-artifact (artifact-passing-lkvj8-1949982165) status Running -> Error
INFO[0029] Updating node artifact-passing-lkvj8[0].generate-artifact (artifact-passing-lkvj8-1949982165) message: failed to save outputs: File or Artifact does not exist. /tmp/hello_world.txt
INFO[0029] Step group node artifact-passing-lkvj8[0] (artifact-passing-lkvj8-1067333159) deemed failed: child 'artifact-passing-lkvj8-1949982165' failed  namespace=default workflow=artifact-passing-lkvj8
INFO[0029] node artifact-passing-lkvj8[0] (artifact-passing-lkvj8-1067333159) phase Running -> Failed  namespace=default workflow=artifact-passing-lkvj8
'''

* fixed gometalinter errcheck issue

workflow/executor/docker/docker.go

@@ -7,6 +7,8 @@ import (
 	"strings"
 	"time"
 
+	"github.com/argoproj/argo/workflow/util/file"
+
 	"github.com/argoproj/argo/util"
 
 	"github.com/argoproj/argo/errors"
@@ -51,6 +53,11 @@ func (d *DockerExecutor) CopyFile(containerID string, sourcePath string, destPat
 	if err != nil {
 		return err
 	}
+	if !file.IsFileOrDirExistInGZip(sourcePath, destPath) {
+		errMsg := fmt.Sprintf("File or Artifact does not exist. %s", sourcePath)
+		log.Warn(errMsg)
+		return errors.InternalError(errMsg)
+	}
 	log.Infof("Archiving completed")
 	return nil
 }

workflow/util/file/fileutil.go

@@ -0,0 +1,52 @@
+package file
+
+import (
+	"archive/tar"
+	"compress/gzip"
+	"io"
+	"os"
+	"strings"
+
+	log "github.com/sirupsen/logrus"
+)
+
+//IsFileOrDirExistInGZip return true if file or directory exists in GZip file
+func IsFileOrDirExistInGZip(sourcePath string, gzipFilePath string) bool {
+
+	fi, err := os.Open(gzipFilePath)
+
+	if os.IsNotExist(err) {
+		return false
+	}
+	defer closeFile(fi)
+
+	fz, err := gzip.NewReader(fi)
+	if err != nil {
+		return false
+	}
+	tr := tar.NewReader(fz)
+	for {
+		hdr, err := tr.Next()
+		if err == io.EOF {
+			break
+		}
+		if err != nil {
+
+			return false
+		}
+		if hdr.FileInfo().IsDir() && strings.Contains(strings.Trim(hdr.Name, "/"), strings.Trim(sourcePath, "/")) {
+			return true
+		}
+		if strings.Contains(sourcePath, hdr.Name) && hdr.Size > 0 {
+			return true
+		}
+	}
+	return false
+}
+
+func closeFile(f *os.File) {
+	err := f.Close()
+	if err != nil {
+		log.Warn("Failed to close the file. v%", err)
+	}
+}