Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump react-router-dom from 4.3.1 to 6.20.0 #481

Conversation

sunyeongchoi
Copy link
Member

#480

dependabot automatically updates the react-router-dom version, but as the version is upgraded 6, the functions used change, causing errors in the build.

So, I changed it to use a function that matches the react-router-dom 16 version.

@agilgur5 agilgur5 added type/dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 6, 2024
@agilgur5 agilgur5 self-assigned this Jan 6, 2024
@agilgur5
Copy link
Contributor

agilgur5 commented Jan 6, 2024

Note that this a (very) breaking change, so it does affect all downstream UI builds as well which we have to be fairly careful with.

I took care of the last remaining react-router v4 piece in Workflows in argoproj/argo-workflows#11891. I haven't checked all v5 to v6 breaking changes yet though. We'd also probably want to upgrade to v5.1 first, per the upgrade guide

Also not sure if CD is able to upgrade. If not possible yet, they'd have to stay on the version before this gets merged.

Copy link

github-actions bot commented Mar 7, 2024

Stale pull request message

@github-actions github-actions bot added the problem/stale This has not had a response in some time label Mar 7, 2024
@github-actions github-actions bot closed this Mar 14, 2024
@agilgur5 agilgur5 changed the title Feature/npm and yarn/react router dom 6.20.0 chore(deps): bump react-router-dom from 4.3.1 to 6.20.0 May 12, 2024
@agilgur5 agilgur5 added solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) and removed solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code problem/stale This has not had a response in some time type/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants