Conversation
6263f38 to
d29b05f
Compare
|
Hi @rbreeze, Which all argo components use argo-ui and also I noticed some (dark) themes written in v2 components, could you please point towards how it works? |
d29b05f to
e26a8f4
Compare
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
d12374f to
5cf81aa
Compare
|
Hi @saumeya, thanks for doing this. To answer your question, the dark components you see are styled based on the theme context which can be accessed with the The theme setting is stored in localStorage; in the Argo Rollouts dashboard, this is toggled on and off with a button for example. |
|
Thanks a lot for approving the PR @rbreeze, could you also merge it? Thanks for explaining the approach used in rollouts. I'll take a deeper look at it. |
View steps to test in the upstream ticket
Upstream ticket - argoproj/argo-cd#9703
The main logic for creating the theme map is in this file - https://github.com/argoproj/argo-ui/pull/245/files#diff-9be47d1a6668e34bf14bd39d2c830ecd572725cac9912f2bcd5e9b6d512ec0f1
In this approach, it will be also easier to add more themes (light, dark, some other theme). Only theme.scss would need to be updated to add a new theme.
All the other places is just adding the
@include themifydirective.Only the background colours are changed.
Some elements like drop downs and popups are not updated because of more complexity, can be updated after this is merged.