refactor: Update notifications engine to latest#2029
Closed
todaywasawesome wants to merge 2 commits intoargoproj:masterfrom
Closed
refactor: Update notifications engine to latest#2029todaywasawesome wants to merge 2 commits intoargoproj:masterfrom
todaywasawesome wants to merge 2 commits intoargoproj:masterfrom
Conversation
Signed-off-by: todaywasawesome <dan@codefresh.io>
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
=======================================
Coverage 82.50% 82.50%
=======================================
Files 120 120
Lines 17054 17054
=======================================
Hits 14070 14070
Misses 2283 2283
Partials 701 701 Continue to review full report at Codecov.
|
Signed-off-by: todaywasawesome <dan@codefresh.io>
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
This PR is stale because it has been open 90 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: todaywasawesome dan@codefresh.io
Notification Engine is several months behind and includes several bug fixes and two additional features.
argoproj/notifications-engine#90
argoproj/notifications-engine#78 and argoproj/notifications-engine#64
argoproj/notifications-engine#85 similar to #1958