Skip to content

fix: build/lint is broken due to dependencies changes #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jessesuen merged 3 commits into from
Apr 5, 2022
Merged

fix: build/lint is broken due to dependencies changes #1958

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1b3523
fix: this fixes the build
zachaller Apr 5, 2022
ea60e9c
fix: add env for go version
zachaller Apr 5, 2022
6035783
fix: copy paste issue
zachaller Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,34 @@ on:
pull_request:
branches:
- "master"
env:
# Golang version to use across CI steps
GOLANG_VERSION: '1.17'

jobs:
lint-go:
name: Lint Go code
runs-on: ubuntu-latest
steps:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: ${{ env.GOLANG_VERSION }}
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Run golangci-lint
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v3
with:
version: v1.30
version: v1.45.2
args: --timeout 5m
build:
name: Build
runs-on: ubuntu-latest
steps:
- name: Set up Go
uses: actions/setup-go@v2
uses: actions/setup-go@v3
with:
go-version: 1.17
go-version: ${{ env.GOLANG_VERSION }}
id: go

- name: Check out code into the Go module directory
Expand Down Expand Up @@ -70,7 +78,7 @@ jobs:
- name: Setup Golang
uses: actions/setup-go@v1
with:
go-version: 1.17.6
go-version: ${{ env.GOLANG_VERSION }}
# k8s codegen generates files into GOPATH location instead of the GitHub git checkout location
# This symlink is necessary to ensure that `git diff` detects changes
- name: Create symlink in GOPATH
Expand Down