Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make codegen more consistent across environments #1095

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Apr 20, 2021

All toolchain binaries (with the exception of protoc, swagger-codegen, and yarn) are now built on the fly using go get <package>@<version> and installed into the dist directory instead of using the system GOBIN path. They also have mostly been removed from go.mod as a dependency, except for the ones needed to be vendored by kubernetes.

Signed-off-by: Jesse Suen [email protected]

@jessesuen jessesuen force-pushed the consistent-toolchain branch from 1796a4c to 92dca95 Compare April 20, 2021 02:13
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1095 (a414b00) into master (31afa28) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   81.23%   81.23%           
=======================================
  Files         103      103           
  Lines        9243     9243           
=======================================
  Hits         7509     7509           
  Misses       1233     1233           
  Partials      501      501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31afa28...a414b00. Read the comment docs.

@jessesuen jessesuen force-pushed the consistent-toolchain branch from 92dca95 to a414b00 Compare April 20, 2021 02:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@jessesuen jessesuen requested a review from rbreeze April 20, 2021 03:04
@jessesuen jessesuen marked this pull request as ready for review April 20, 2021 17:50
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jessesuen jessesuen merged commit 0f131a7 into argoproj:master Apr 20, 2021
@jessesuen jessesuen deleted the consistent-toolchain branch April 20, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants