fix(argo-cd): Upgrade redis-ha to v4.10.4 #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giskou
requested review from
davidkarlsen,
seanson,
spencergilbert and
yann-soubeyrand
as code owners
giskou
changed the title
Signed-off-by: Ioannis Skoulis <[email protected]>
Changelog: DandyDeveloper/charts@9a33438...a83e96d Signed-off-by: Ioannis Skoulis <[email protected]>
yann-soubeyrand
approved these changes
Mar 8, 2021
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
Changelog: DandyDeveloper/charts@9a33438...a83e96d Signed-off-by: Ioannis Skoulis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the redis-ha helm chart to v4.10.4 from v4.10.1.
Changelog: DandyDeveloper/charts@9a33438...a83e96d
The main reason is to fix the kubernetes probes for redis.
We have been hit by an issue similar to bitnami/charts#2441 where the liveness/readiness probes leave lots of zombie processes behind that eventually starve the system from threads and PIDs.
The timeout that wraps the redis-cli call is always left as defunc even though the probes actually succeed.
redis-ha v4.10.4 totally removed the timeout, while everything still works as expected.
The timeout was introduced in helm/charts#11355 as a workaround for kubernetes/kubernetes#58925 which has been fixed a long time ago.
Checklist:
Chart.yamlfollowing Semantic Versioning.Changes are automatically published when merged to
master. They are not published on branches.