Skip to content

feat(argo-cd): add the requeue setting for appsets#3144

Closed
aburan28 wants to merge 1 commit intoargoproj:mainfrom
aburan28:adam--add-appset-option
Closed

feat(argo-cd): add the requeue setting for appsets#3144
aburan28 wants to merge 1 commit intoargoproj:mainfrom
aburan28:adam--add-appset-option

Conversation

@aburan28
Copy link
Copy Markdown

@aburan28 aburan28 commented Jan 27, 2025

Simple PR that adds the option added in the following PR

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: aburan28 <aburan28@gmail.com>
@aburan28 aburan28 changed the title add the requeue setting for appsets feat: add the requeue setting for appsets Jan 27, 2025
@aburan28 aburan28 changed the title feat: add the requeue setting for appsets feat(argo-cd): add the requeue setting for appsets Jan 27, 2025
@aburan28 aburan28 marked this pull request as ready for review January 27, 2025 23:00
@mkilchhofer mkilchhofer added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Jan 28, 2025
@mkilchhofer
Copy link
Copy Markdown
Member

Hi @aburan28, Thanks for your contribution.
While your mentioned PR is merged, it is not released (if you navigate to https://github.com/argoproj/argo-cd/blob/v2.13.3/manifests/base/applicationset-controller/argocd-applicationset-controller-deployment.yaml , you see that the ENV var is not yet present).

Therefore I add the awaiting-upstream label and we revisit your PR after we observe that the feature is now available inside a released version.

@github-actions

This comment has been minimized.

@mkilchhofer mkilchhofer added on-hold Issues or Pull Requests with this label will never be considered stale and removed no-pr-activity labels Mar 30, 2025
@mkilchhofer
Copy link
Copy Markdown
Member

Hi @aburan28 thanks for your patience 🙏 . It is already available since a while ago (Feb 4, 2025, Helm chart version 7.8.0)
Ref:

Let us close this :)

@mkilchhofer mkilchhofer closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. on-hold Issues or Pull Requests with this label will never be considered stale size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants