feat(argo-cd): Support livenessProbe for Application Controller

[yu-croco]

Resolves #2973

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

[yu-croco]

same as readinessProbe 📝
Ref: https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/templates/argocd-application-controller/deployment.yaml#L304-L307

[yu-croco]

same as readinessProbe 📝
Ref: https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/templates/argocd-application-controller/statefulset.yaml#L303-L306

[mkilchhofer]

We should place a (prominent) note that this can have side effects.

We once had the probes on the application-controller but due to an (upstream) issue, upstream removed it and thus we also removed it in the helm chart.

Current controller liveness probe is a noop just checking if the metric-server is able to receive requests.

In cases when the controller is overloaded reconciling large queues restarting the Pod is more harmful than letting it running. In discussion with @alexmt we understand that liveness probe should be removed from the controller to prevent it from being restarted.

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

Xref:

• argoproj/argo-cd#9557
• #1581

[yu-croco]

@mkilchhofer Thank you for your review with the backgroud.
It seems that it's not worth to take risk even it's optional... 🤔