Skip to content

fix(argo-cd): fix(argo-cd): Fix dex-server-tls.yaml template name #1675

Closed
karlparry wants to merge 1 commit intoargoproj:mainfrom
karlparry:fix-argocd-dex-template
Closed

fix(argo-cd): fix(argo-cd): Fix dex-server-tls.yaml template name #1675
karlparry wants to merge 1 commit intoargoproj:mainfrom
karlparry:fix-argocd-dex-template

Conversation

@karlparry
Copy link
Contributor

The deployment does an import to create a checksum of this file but this template is named incorrectly

Signed-off-by: Karl Parry karl.parry@imbursepayments.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to main. They are not published on branches.

The deployment does an import to create a checksum of this file but this template is [named incorrectly](https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/templates/dex/deployment.yaml#L19)

Signed-off-by: Karl Parry <karl.parry@imbursepayments.com>
@jmeridth
Copy link
Member

How about change the name in the deployment instead of renaming the file? The -secret suffix is a standard I'd like to keep.

@karlparry
Copy link
Contributor Author

Will correct them to contain the secret suffix 👍

@karlparry karlparry closed this Nov 30, 2022
@karlparry karlparry changed the title fix(argo-cd): Fix dex-server-tls.yaml template name fix(argo-cd): Rename tls secret to include the -secret suffix Nov 30, 2022
@karlparry karlparry changed the title fix(argo-cd): Rename tls secret to include the -secret suffix fix(argo-cd): fix(argo-cd): Fix dex-server-tls.yaml template name Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants