fix(argo-workflows): serviceaccount rbac when sso is enabled

[nxf5025]

Fixes: #1572

Removed the sso.rbac map as it breaks the sso integration. Also if the sso block is used we should include serviceaccount in our clusterrole instead of being managed by another setting.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

Changes are automatically published when merged to main. They are not published on branches.

[vladlosev]

This change grants access to service accounts even when it's not needed. Not every organization wants to give every app access unnecessary access. As an alternative, you can simply remove the rbac element when using sso to generate the config map:

argo-helm/charts/argo-workflows/templates/controller/workflow-controller-config-map.yaml

Line 134 in aa66902

{{- with .rbac }}

.

[vladlosev]

LGTM

[whereismyjetpack]

I'm not certain why, but I'm pretty sure this change has the inverse effect in my environment, when there isn't an rbac stanza in the configmap, all users have default rbac, which appears to be the sa that argo is using, i had to manually add rbac.enabled in the configmap to get the old behavior

[agilgur5]

For any future readers, this was reverted in #1641 (comment). See also #1638