feat(argo-cd): Move argocd-cm and argocd-rbac-cm to config section#1528
Merged
pdrastil merged 1 commit intoargoproj:mainfrom Oct 25, 2022
Merged
feat(argo-cd): Move argocd-cm and argocd-rbac-cm to config section#1528pdrastil merged 1 commit intoargoproj:mainfrom
pdrastil merged 1 commit intoargoproj:mainfrom
Conversation
pdrastil
requested review from
davidkarlsen,
jmeridth,
mbevc1,
mkilchhofer,
radiomistress,
yann-soubeyrand and
yu-croco
as code owners
pdrastil
force-pushed
the
feature/cm
branch
11 times, most recently
from
197a88c to
1cfd0c8
Compare
pdrastil
commented
Oct 22, 2022
Member
Author
There was a problem hiding this comment.
Coalesce makes this backward compatible change - Users can upgrade and then migrate to new section.
pdrastil
force-pushed
the
feature/cm
branch
6 times, most recently
from
30876f4 to
4c5e38c
Compare
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
jmeridth
approved these changes
Oct 25, 2022
Member
jmeridth
left a comment
jmeridth
left a comment
There was a problem hiding this comment.
LGTM 👍
The coalesce allows for backwards compatibility. Nice.
stemar94
reviewed
Oct 26, 2022
3 tasks
6 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #1519
Decouple argocd-cm and argocd-rbac-cm from server component and keep this together with rest of the configs. Backward compatibility ensured with coalesce and deprecation notice.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.