docs(sensor): move parameters to template level #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepke
changed the title
Signed-off-by: Joep Keijsers <[email protected]>
joepke
force-pushed
the
docs/fix-sensor-parameterization-example
branch
from
addbda1 to
09489f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the trigger parameterization example from https://argoproj.github.io/argo-events/tutorials/02-parameterization/, as mentioned in #3432 and #3161.
The outer
parameterssection should be at template level, as defined in the Trigger spec (https://argoproj.github.io/argo-events/APIs/#argoproj.io/v1alpha1.Trigger).The other trigger parameterization example is configured correctly (https://github.com/argoproj/argo-events/blob/master/examples/sensors/complete-trigger-parameterization.yaml).