Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump sarama to v1.41.2 #2823

Merged
merged 2 commits into from
Sep 25, 2023
Merged

chore(deps): bump sarama to v1.41.2 #2823

merged 2 commits into from
Sep 25, 2023

Conversation

dnwe
Copy link
Contributor

@dnwe dnwe commented Sep 25, 2023

Note: the module path has changed to github.com/IBM/sarama since ownership transitioned away from Shopify

Fixes #2554

Note: the module path has changed to github.com/IBM/sarama since ownership transitioned away from Shopify

Signed-off-by: Dominic Evans <[email protected]>
Sarama deprecated the old global BalanceStrategy global instances (which
would inadvertently share state) in favour of creating dedicated
instances. Use the replacement func.

Signed-off-by: Dominic Evans <[email protected]>
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whynowy whynowy merged commit 11d9aef into argoproj:master Sep 25, 2023
8 checks passed
@dnwe dnwe deleted the sarama branch September 25, 2023 20:14
joelcomp1 pushed a commit to joelcomp1/argo-events that referenced this pull request Sep 26, 2023
Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: jmillage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sarama library for Kafka no longer supported
2 participants