feat: ApplicationSet controller sharding (#9002)#9568
feat: ApplicationSet controller sharding (#9002)#9568hcelaloner wants to merge 1 commit intoargoproj:masterfrom
Conversation
…er to applicationset controller Fixes argoproj#9002 Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com> Co-authored-by: Doğukan Tuna <dogukan.tuna@trendyol.com> Signed-off-by: Celal Öner <celal.oner@trendyol.com>
Codecov Report
@@ Coverage Diff @@
## master #9568 +/- ##
==========================================
+ Coverage 45.77% 45.84% +0.06%
==========================================
Files 222 223 +1
Lines 26372 26412 +40
==========================================
+ Hits 12072 12108 +36
- Misses 12651 12654 +3
- Partials 1649 1650 +1
Continue to review full report at Codecov.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else { | ||
| h := fnv.New32a() | ||
| _, _ = h.Write([]byte(id)) | ||
| return int(h.Sum32() % uint32(replicas)) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
crenshaw-dev
changed the title
|
Hi, we tried to provide an initial implementation for sharding based on ArgoCD's existing implementation. However, I guess it is not completed, we may need to convert deployment to statefulset as in ArgoCD application controller. If this feature is ok for you guys, can you guide us about missing parts or any preferred approaches on the codebase. We are using appsets heavily (~2k appsets ~8k apps) and facing some scalability issue, we would like to contribute as much as we can. |
|
Hey @hcelaloner , I would request you to create proposal and discuss it before doing any architectural changes |
@rishabh625 could you give me an example to understand the expectation from the proposal? In #9002, I tried to propose this as a solution but it was a one-sentence, I can try to give some details on the idea in that issue. |
I meant enhancement propsal , probably you could add more of your thinking in #9002 or here itself, i m good for now |
2 participants
Fixes #9002
Co-authored-by: Erkan Zileli erkan.zileli@trendyol.com
Co-authored-by: Doğukan Tuna dogukan.tuna@trendyol.com
Signed-off-by: Celal Öner celal.oner@trendyol.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: