refactor: Update notification engine #9386
Merged
alexmt merged 3 commits intoargoproj:masterfrom May 23, 2022
Merged
Conversation
Signed-off-by: todaywasawesome <dan@codefresh.io>
Codecov Report
@@ Coverage Diff @@
## master #9386 +/- ##
==========================================
- Coverage 46.22% 45.71% -0.51%
==========================================
Files 218 221 +3
Lines 25914 26289 +375
==========================================
+ Hits 11978 12019 +41
- Misses 12278 12610 +332
- Partials 1658 1660 +2
Continue to review full report at Codecov.
|
Member
|
@todaywasawesome I'm not opposed! Looks like it needs a |
Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: todaywasawesome <dan@codefresh.io>
alexmt
approved these changes
May 23, 2022
Collaborator
alexmt
left a comment
There was a problem hiding this comment.
Reviewed changes in notification-engine one more time .
Looks like PR would pull in several bug fixes and new features that would be good to test. So I think it is good idea to bump notification engine version even though we are very close to the release.
alexmt
pushed a commit
that referenced
this pull request
May 24, 2022
refactor: Update notification engine (#9386) Signed-off-by: todaywasawesome <dan@codefresh.io>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: todaywasawesome dan@codefresh.io
Notification Engine is several months behind and includes several bug fixes and two additional features.
@crenshaw-dev @alexmt There is an open question if we should cherrypick this into 2.4. Given how far behind the current package is, my instinct is that we should include it. Argo Rollouts is using a version from Jan '22 while CD is using one from Nov '21.
CC @kevinchen-verkada who is advocating for these changes.