feat: Make spec.source.helm.values field accepts either a string or a rawExtension

[crenshaw-dev]

#8794 plus some changes I'd requested.

Fixes #2936

This change makes it possible to store either a string or a map in spec.source.helm.values. Using a map will allow people to kustomize-patch the values field.

[codecov]

Codecov Report

Base: 45.51% // Head: 45.57% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (0990517) compared to base (67e45d8).
Patch coverage: 79.68% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9079      +/-   ##
==========================================
+ Coverage   45.51%   45.57%   +0.06%     
==========================================
  Files         217      218       +1     
  Lines       25663    25715      +52     
==========================================
+ Hits        11680    11720      +40     
- Misses      12355    12368      +13     
+ Partials     1628     1627       -1     

Impacted Files	Coverage Δ
cmd/argocd/commands/app.go	9.16% <0.00%> (ø)
.../apis/application/v1alpha1/stringorobject_types.go	75.60% <75.60%> (ø)
cmd/util/app.go	54.18% <89.47%> (+3.78%)	⬆️
pkg/apis/application/v1alpha1/types.go	54.63% <100.00%> (ø)
reposerver/repository/repository.go	59.70% <100.00%> (ø)
applicationset/services/scm_provider/github.go	63.52% <0.00%> (-17.65%)	⬇️
applicationset/services/scm_provider/utils.go	88.50% <0.00%> (+4.59%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[tiagomeireles]

Curious if this will make it into 2.4?

[crenshaw-dev]

@tiagomeireles I doubt it. It's very close, but I want to try using a RawExtension at the root of values instead of nesting it. That'll make the code easier to read and will avoid an ugly jq hack in the swagger generation code.

[crenshaw-dev]

Closing until I have time to give this another shot.

[therapy-lf]

seeking for this feature 😞

[crenshaw-dev]

Taking volunteers to pick this back up! I'd happily provide guidance. Just don't have time to finish it.

[alexef]

@crenshaw-dev I would like to pick this up 👋

[crenshaw-dev]

@alexef brilliant, lmk how I can help!