chore: tests for app cmd#8918
Conversation
pasha-codefresh
commented
Mar 28, 2022
pasha-codefresh
commented
- appURLDefault
- truncateString
- getServer
- targetObjects
- printApplicationNames
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io> # Conflicts: # OWNERS
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Codecov Report
@@ Coverage Diff @@
## master #8918 +/- ##
==========================================
+ Coverage 43.30% 43.40% +0.09%
==========================================
Files 186 186
Lines 23359 23373 +14
==========================================
+ Hits 10116 10145 +29
+ Misses 11797 11779 -18
- Partials 1446 1449 +3
Continue to review full report at Codecov.
|
| if result != expectation { | ||
| t.Fatalf("Incorrect url %q, should be %q", result, expectation) | ||
| } |
There was a problem hiding this comment.
| if result != expectation { | |
| t.Fatalf("Incorrect url %q, should be %q", result, expectation) | |
| } | |
| assert.Equal(t, expectation, result, "Incorrect url %q, should be %q", result, expectation) |
nit: should we follow the convention of assert ?
There was a problem hiding this comment.
Sorry! I didn't see the PR is merged
There was a problem hiding this comment.
No worries, it's a good point! We could probably use a cleanup PR to switch over to assert.
There was a problem hiding this comment.
i will fix it, im going to push more tests, thank you @crenshaw-dev @chetan-rns
There was a problem hiding this comment.
@chetan-rns i think i wrote like this because all assertions in this file with if conditions, but definitely I will work to fix it in all the places
* add to approvers Signed-off-by: pashavictorovich <pavel@codefresh.io> * application tests Signed-off-by: pashavictorovich <pavel@codefresh.io> * application tests Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
3 participants
