feature: adding kube-context flag#8849
Merged
pasha-codefresh merged 3 commits intoargoproj:masterfrom Apr 7, 2022
codefresh-contrib:CR-8129
Merged
feature: adding kube-context flag#8849pasha-codefresh merged 3 commits intoargoproj:masterfrom codefresh-contrib:CR-8129
pasha-codefresh merged 3 commits intoargoproj:masterfrom
codefresh-contrib:CR-8129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8849 +/- ##
==========================================
+ Coverage 45.00% 45.02% +0.02%
==========================================
Files 212 212
Lines 25272 25284 +12
==========================================
+ Hits 11373 11385 +12
- Misses 12292 12295 +3
+ Partials 1607 1604 -3
Continue to review full report at Codecov.
|
Contributor
|
Good job on your first PR @elad-codefresh ! |
Contributor
Author
|
enhancement proposal: |
elad-codefresh
changed the title
…if wanted. #8829 Signed-off-by: elad-codefresh <elad.laor@codefresh.io>
Signed-off-by: elad-codefresh <elad.laor@codefresh.io>
Signed-off-by: elad-codefresh <elad.laor@codefresh.io>
Member
|
Thank you, just one comment, Why are you doing clientOpts.KubeOverrides.CurrentContext and not clientOpts.Context? |
pasha-codefresh
approved these changes
Apr 7, 2022
Member
pasha-codefresh
left a comment
pasha-codefresh
left a comment
There was a problem hiding this comment.
Great job, thank you!
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Apr 9, 2022
* feature: adding support for kube-context flag to override kubeconfig if wanted. argoproj#8829 Signed-off-by: elad-codefresh <elad.laor@codefresh.io> * feat: fixed lint Signed-off-by: elad-codefresh <elad.laor@codefresh.io> * feat: codegen Signed-off-by: elad-codefresh <elad.laor@codefresh.io> Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
wojtekidd
pushed a commit
to wojtekidd/argo-cd
that referenced
this pull request
Apr 25, 2022
* feature: adding support for kube-context flag to override kubeconfig if wanted. argoproj#8829 Signed-off-by: elad-codefresh <elad.laor@codefresh.io> * feat: fixed lint Signed-off-by: elad-codefresh <elad.laor@codefresh.io> * feat: codegen Signed-off-by: elad-codefresh <elad.laor@codefresh.io> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
|
Should this work in 2.3.4? The documented --kube-context string doesn't seem to work for me. Thanks |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: