feat: add 'argocd admin cluster shard balance' command#8002
Closed
alexmt wants to merge 1 commit intoargoproj:masterfrom
Closed
feat: add 'argocd admin cluster shard balance' command#8002alexmt wants to merge 1 commit intoargoproj:masterfrom
alexmt wants to merge 1 commit intoargoproj:masterfrom
Conversation
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8002 +/- ##
==========================================
- Coverage 41.49% 41.34% -0.16%
==========================================
Files 173 173
Lines 22591 22673 +82
==========================================
Hits 9375 9375
- Misses 11885 11967 +82
Partials 1331 1331
Continue to review full report at Codecov.
|
10 tasks
Member
|
@alexmt i would close this one, please feel free to reopen if you plan to work on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
WIP PR that is supposed to resolve #6125
PR adds command
argocd cluster shards balancethat distribute clusters between available controller shards based on number of resources in each shard. During the testing, I've discovered that resources count and amount of used memory do not correlate at all. The table below contains snapshot of argocd that manages ~300 clusters:Shard #5 manages clusters with ~50% less than average resources but consumes 75% more memory. After rebalancing memory usage got even more uneven. So keep it as a draft for now and try to find a better metric than the number of resources.