feat: Add app list and details page views to navigation history (#7776)

[keithchong]

Signed-off-by: Keith Chong kykchong@redhat.com

Fixes #7776

Both Application List page view and Details page views are added to the navigation history

Some points to consider:

A. Tab independence (For a specific situation when view is not a query parameter)

1. Open a new browser window
2. In a new tab (tab A) go to https://cd.apps.argoproj.io/
   —> App List page
3. Open a new tab (tab B) and go to https://cd.apps.argoproj.io/
   —> App List page
4. In this current tab, switch to the Summary page
5. Switch back to tab A
   —> The page refreshed to the Summary page. This is because it gets the last preferred view

With the fix, the tab will remain on the Tiles view. Launching Argo CD UI without view the query param will always show the Tiles view.

B. With the fix, Clicking on the Sync Windows link brings you to the Settings page and then you want to click on Back to go back to the details page.

C. With the fix, Back and Forward button 'history' will have new unique titles. eg. "Application List - Argo CD"

D. With the fix, the Tool bar title text is now dynamic, but if you want it to remain the same as before, we just have to revert the title change.

eg. original titles for the app list page and details page, respectively:
"APPLICATIONS" and "APPLICATION DETAILS"

With Fix:
"APPLICATIONS TILES", "APPLICATIONS LIST", "APPLICATIONS SUMMARY"

"APPLICATION DETAILS TREE", "APPLICATION DETAILS PODS", "APPLICATION DETAILS NETWORK", "APPLICATION DETAILS LIST"

E. Behaviour of the Back and Forward buttons on the App List page presented additional issues that do not exist in the details page.

F. Clicking on the Applications link from the details page will bring you back to the Tiles view of the applications list page, because of point A.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #7937 (0946c36) into master (27af0b4) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7937      +/-   ##
==========================================
- Coverage   41.53%   41.53%   -0.01%     
==========================================
  Files         174      174              
  Lines       22736    22705      -31     
==========================================
- Hits         9443     9430      -13     
+ Misses      11949    11921      -28     
- Partials     1344     1354      +10     

Impacted Files	Coverage Δ
controller/sync.go	57.51% <0.00%> (-7.63%)	⬇️
server/application/application.go	31.20% <0.00%> (-1.45%)	⬇️
util/session/sessionmanager.go	68.75% <0.00%> (-1.37%)	⬇️
reposerver/repository/repository.go	57.80% <0.00%> (-0.84%)	⬇️
util/localconfig/localconfig.go	2.77% <0.00%> (-0.32%)	⬇️
server/project/project.go	52.50% <0.00%> (-0.19%)	⬇️
util/clusterauth/clusterauth.go	66.66% <0.00%> (-0.16%)	⬇️
util/rbac/rbac.go	76.47% <0.00%> (-0.03%)	⬇️
util/argo/diff/diff.go	52.27% <0.00%> (ø)
util/argo/diff/ignore.go	100.00% <0.00%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27af0b4...0946c36. Read the comment docs.

[ciiay]

Looks good to me! Only added a few code improvement suggestions, and I know we are not doing destructuring in this whole project ... I hope in the next UI version we can do more destructuring so that we don't have to write props. every time.

[keithchong]

Rebased. Hi @alexmt or @pasha-codefresh, could either one of you review this and try it out?

[alexmt]

The application details page already loads view preferences and uses the correct view type. As far as I understand there is no specify view type in query parameter here.

[keithchong]

Hi @alexmt, yeah, it loads and selects the proper view fine, initially. It's just that we need to properly register it in the navigation history. Try this, with and without the changes to this file, for comparison:

1. Launch Argo CD UI in a new browser tab, with existing apps already created
2. Drill down to the details view of an application
3. Switch to another view of the app (eg network or pods)
4. Press the Back button
   --> It does not change the view (without the changes to this file)

[keithchong]

Actually. we need to force using the query parameter, otherwise, the view doesn't change because the current view is actually the preferred view.

[alexmt]

Thank you @keithchong . LGTM