feat: tracking method in app#7322
feat: tracking method in app#7322pasha-codefresh wants to merge 41 commits intoargoproj:masterfrom pasha-codefresh:tracking-method-in-app
Conversation
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…resh/argo-cd into rename-app-id � Conflicts: � reposerver/apiclient/repository.pb.go
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…resh/argo-cd into rename-app-id � Conflicts: � util/settings/settings.go
…resh/argo-cd into rename-app-id
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…resh/argo-cd into rename-app-id
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…f github.com:pasha-codefresh/argo-cd into rename-app-id-value-convention
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…king-method-app-id-value-convention-e2e
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…ue-convention-e2e Tracking method app id value convention e2e
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…pasha-codefresh/argo-cd into tracking-method-in-app � Conflicts: � controller/cache/cache.go � controller/state.go � reposerver/repository/repository.go � server/application/application.go � util/argo/argo.go � util/argo/resource_tracking.go � util/argo/resource_tracking_test.go � util/settings/settings.go
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…sha-codefresh/argo-cd into tracking-method-in-app � Conflicts: � util/argo/resource_tracking.go � util/argo/resource_tracking_test.go
Codecov Report
@@ Coverage Diff @@
## master #7322 +/- ##
==========================================
- Coverage 41.17% 41.16% -0.02%
==========================================
Files 161 161
Lines 21612 21632 +20
==========================================
+ Hits 8899 8904 +5
- Misses 11446 11460 +14
- Partials 1267 1268 +1
Continue to review full report at Codecov.
|
alexmt
left a comment
There was a problem hiding this comment.
@jessesuen suggested a great idea about how to make transition seamless and avoid adding app-level config. Instead we can add programmatically ignore the difference if missing annotation and extract tracking label is the only detected difference. We leverage "diff normalizers" to archive it: https://github.com/argoproj/argo-cd/tree/master/util/argo/normalizers
The normalizer is supposed to remove fields which should not be compared from the resource. You can use https://github.com/argoproj/argo-cd/blob/master/util/argo/normalizers/diff_normalizer.go as an example
|
Thank you @alexmt @jessesuen , i will implement it in few days |
Continuation for #7251
Provide ability override tracking method on application level