feat: tracking method for annotations should be in another format#7316
Merged
alexmt merged 8 commits intoargoproj:masterfrom Sep 29, 2021
pasha-codefresh:tracking-method-app-id-value-convention
Merged
feat: tracking method for annotations should be in another format#7316alexmt merged 8 commits intoargoproj:masterfrom pasha-codefresh:tracking-method-app-id-value-convention
alexmt merged 8 commits intoargoproj:masterfrom
pasha-codefresh:tracking-method-app-id-value-convention
Conversation
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Codecov Report
@@ Coverage Diff @@
## master #7316 +/- ##
==========================================
+ Coverage 41.15% 41.23% +0.07%
==========================================
Files 161 161
Lines 21553 21581 +28
==========================================
+ Hits 8871 8899 +28
Misses 11415 11415
Partials 1267 1267
Continue to review full report at Codecov.
|
…king-method-app-id-value-convention-e2e
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…ue-convention-e2e Tracking method app id value convention e2e
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation for #7251
In case if tracking method defined as annotation resource id format should be "application-name;group/kind/namespace/name"
In case if tracking method is "label" or not defined nothing should be changed