Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support remote GKE clusters #6514

Closed
wants to merge 3 commits into from
Closed

feat: Support remote GKE clusters #6514

wants to merge 3 commits into from

Conversation

epk
Copy link

@epk epk commented Jun 21, 2021 •
edited
Loading

Closes #3027

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates? <---- unsure, but my guess is yes?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@epk epk force-pushed the epk/gcp-auth branch 3 times, most recently from 44f9e83 to 8aab409 Compare June 21, 2021 16:19
@epk epk changed the title Feat: Support remote GKE clusters feat: Support remote GKE clusters Jun 21, 2021
alexmt
alexmt reviewed Jun 21, 2021
View reviewed changes
go.mod
@@ -86,13 +88,10 @@ require (
)

replace (
github.com/golang/protobuf => github.com/golang/protobuf v1.4.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really tried to upgrade protobuf and grpc (started from argo-rollouts). Here is description of why it is not done yet: argoproj/argo-rollouts#1091

@epk epk closed this Jul 8, 2021
@Matroxt
Copy link

Matroxt commented Jul 13, 2021

Is the protobuf package version required for this PR to pass?
This issue is pretty important for us and I'd like to understand why it's closed without resolution.

@Matroxt Matroxt mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GKE Authentication on Remote Cluster
3 participants
@epk @Matroxt @alexmt