Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove usages of k8s.io/kubernetes (#4055) #5434

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

jMarkP
Copy link
Contributor

@jMarkP jMarkP commented Feb 6, 2021

Towards #4055 and #5173 (once argoproj/gitops-engine#205 and argoproj/gitops-engine#206 have been merged at least).

The argo-cd repo only has a few direct references to k8s.io/kubernetes:

I've run make build and make test on this change and it seems healthy.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

@jMarkP jMarkP force-pushed the remove-k8s-kubernetes branch 2 times, most recently from c60053d to 824abe6 Compare February 6, 2021 19:05
@codecov-io
Copy link

codecov-io commented Feb 6, 2021

Codecov Report

Merging #5434 (0b97da5) into master (bb15a49) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5434   +/-   ##
=======================================
  Coverage   40.94%   40.94%           
=======================================
  Files         137      137           
  Lines       18613    18613           
=======================================
  Hits         7621     7621           
  Misses       9905     9905           
  Partials     1087     1087           
Impacted Files Coverage Δ
controller/cache/info.go 63.54% <0.00%> (ø)
server/account/account.go 69.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb15a49...0b97da5. Read the comment docs.

@jMarkP jMarkP changed the title chore: Remove usages of k8s.io/kubernetes chore: Remove usages of k8s.io/kubernetes (#4055) Feb 6, 2021
Signed-off-by: Mark Pim <[email protected]>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement and detailed PR description! LGTM

@alexmt alexmt merged commit c540b71 into argoproj:master Feb 10, 2021
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
)

* chore:Remove usages of k8s.io/kubernetes

Signed-off-by: Mark Pim <[email protected]>

* Linting fix

Signed-off-by: Mark Pim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants