feat: support application names more than 63 chars long#4051
feat: support application names more than 63 chars long#4051YGwen wants to merge 6 commits intoargoproj:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4051 +/- ##
==========================================
- Coverage 42.42% 42.33% -0.10%
==========================================
Files 123 123
Lines 18229 18232 +3
==========================================
- Hits 7734 7718 -16
- Misses 9493 9516 +23
+ Partials 1002 998 -4
Continue to review full report at Codecov.
|
|
I don't think you'll be able to hash the app name since you lose information about the app name which is required for other purposes. I think the approach that you will need to take, is that we allow the app name to be annotated on the resource instead of labeled. |
|
My understanding was that the label was only used for synchronizing purposes though. Have you found places that use the label and expect a match between it and the app name? |
|
@jessesuen both @YGwen and I see no reason why this fix would not work. Can you show anything to the contrary? This seems like a quick-win intermediate solution for longer names. |
|
This could either be closed or revived to use the new approach? |
|
I suggest to use |
|
Superseded by #7251 |
Checklist: