chore: Code coverage offensive #1: util/dex#3305
Merged
alexmt merged 7 commits intoargoproj:masterfrom Mar 29, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3305 +/- ##
==========================================
+ Coverage 38.96% 39.24% +0.27%
==========================================
Files 173 175 +2
Lines 18894 19011 +117
Branches 237 272 +35
==========================================
+ Hits 7362 7460 +98
- Misses 10617 10624 +7
- Partials 915 927 +12
Continue to review full report at Codecov.
|
alexmt
approved these changes
Mar 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code coverage offensive
This is the first part of an effort to increase our overall code coverage for tests to an acceptable limit.
The PR adds units test for
util/dexpackage with a package coverage of 88.5%. Previous package coverage was 0% (not a single test).Checklist: