fix: skip token refresh threshold parsing in unrelated components #26803
Merged
gdsoumya merged 2 commits intoargoproj:masterfrom Mar 12, 2026
Merged
fix: skip token refresh threshold parsing in unrelated components #26803gdsoumya merged 2 commits intoargoproj:masterfrom
gdsoumya merged 2 commits intoargoproj:masterfrom
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
nitishfy
reviewed
Mar 12, 2026
0cd2106 to
ba77dba
Compare
ba77dba to
65be090
Compare
nitishfy
reviewed
Mar 12, 2026
nitishfy
reviewed
Mar 12, 2026
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
65be090 to
85016c4
Compare
blakepettersson
approved these changes
Mar 12, 2026
|
❌ Cherry-pick failed for 3.2. Please check the workflow logs for details. |
|
❌ Cherry-pick failed for 3.3. Please check the workflow logs for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #26803 +/- ##
==========================================
+ Coverage 62.93% 62.95% +0.01%
==========================================
Files 414 414
Lines 56152 56154 +2
==========================================
+ Hits 35340 35352 +12
+ Misses 17450 17444 -6
+ Partials 3362 3358 -4 ☔ View full report in Codecov by Sentry. |
gdsoumya
added a commit
to gdsoumya/argo-cd
that referenced
this pull request
Mar 12, 2026
…goproj#26803) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run our argocd controllers (everything except argocd-server) with restricted access to specific secrets which includes restricted access to argocd-secret. This causes the controllers to be unable to process any secret replacement logic which is unnecessary for the component anyway. A recent change #23727 added logic that required the secret replacement for every component irrespective of whether the values are used, but given our restricted setup controllers with no access to the secret keep spamming error logs causing unnecessary alerts and log volume.
This PR attempts to fix this by avoiding this requirement for components that don't need the secret.
Checklist: