Skip to content

fix: skip token refresh threshold parsing in unrelated components #26803

Merged
gdsoumya merged 2 commits intoargoproj:masterfrom
gdsoumya:fix/ignore-token-refresh
Mar 12, 2026
Merged

fix: skip token refresh threshold parsing in unrelated components #26803
gdsoumya merged 2 commits intoargoproj:masterfrom
gdsoumya:fix/ignore-token-refresh

Conversation

@gdsoumya
Copy link
Member

@gdsoumya gdsoumya commented Mar 12, 2026

We run our argocd controllers (everything except argocd-server) with restricted access to specific secrets which includes restricted access to argocd-secret. This causes the controllers to be unable to process any secret replacement logic which is unnecessary for the component anyway. A recent change #23727 added logic that required the secret replacement for every component irrespective of whether the values are used, but given our restricted setup controllers with no access to the secret keep spamming error logs causing unnecessary alerts and log volume.

This PR attempts to fix this by avoiding this requirement for components that don't need the secret.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link

bunnyshell bot commented Mar 12, 2026

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@gdsoumya gdsoumya force-pushed the fix/ignore-token-refresh branch from 0cd2106 to ba77dba Compare March 12, 2026 09:22
@gdsoumya gdsoumya changed the title fix: ignore token refresh in unrelated components fix: do not calculate token refresh threshold in unrelated components Mar 12, 2026
@gdsoumya gdsoumya changed the title fix: do not calculate token refresh threshold in unrelated components fix: skip token refresh threshold parsing in unrelated components Mar 12, 2026
@gdsoumya gdsoumya force-pushed the fix/ignore-token-refresh branch from ba77dba to 65be090 Compare March 12, 2026 09:24
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya gdsoumya force-pushed the fix/ignore-token-refresh branch from 65be090 to 85016c4 Compare March 12, 2026 09:43
@gdsoumya gdsoumya marked this pull request as ready for review March 12, 2026 09:48
@gdsoumya gdsoumya requested a review from a team as a code owner March 12, 2026 09:48
@blakepettersson blakepettersson added the cherry-pick/3.3 Candidate for cherry picking into the 3.3 release label Mar 12, 2026
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nitishfy nitishfy added the cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch label Mar 12, 2026
@gdsoumya gdsoumya enabled auto-merge (squash) March 12, 2026 10:02
@gdsoumya gdsoumya merged commit 6df1a5b into argoproj:master Mar 12, 2026
38 of 41 checks passed
@argo-cd-cherry-pick-bot
Copy link

❌ Cherry-pick failed for 3.2. Please check the workflow logs for details.

@argo-cd-cherry-pick-bot
Copy link

❌ Cherry-pick failed for 3.3. Please check the workflow logs for details.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.95%. Comparing base (f1c5201) to head (8f2efd9).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26803      +/-   ##
==========================================
+ Coverage   62.93%   62.95%   +0.01%     
==========================================
  Files         414      414              
  Lines       56152    56154       +2     
==========================================
+ Hits        35340    35352      +12     
+ Misses      17450    17444       -6     
+ Partials     3362     3358       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gdsoumya added a commit to gdsoumya/argo-cd that referenced this pull request Mar 12, 2026
…goproj#26803)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch cherry-pick/3.3 Candidate for cherry picking into the 3.3 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants