fix: Port #18133 to support Docker config for oras client#25614
Closed
frekw wants to merge 1 commit intoargoproj:masterfrom
Closed
fix: Port #18133 to support Docker config for oras client#25614frekw wants to merge 1 commit intoargoproj:masterfrom
frekw wants to merge 1 commit intoargoproj:masterfrom
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
This backports the fix in argoproj#18133 to fallback to the local Docker config (~/.docker/config.json) in the absence of other credentials. This should make private OCI repositories like Google's Artifact Registry work via Docker credential helpers like `docker-credential-gcr`, allowing authentication to seamlessly happen via workload identity. Signed-off-by: frekw <fredrik@warnsberg.se>
36e5511 to
d5e70c3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25614 +/- ##
==========================================
+ Coverage 62.59% 62.60% +0.01%
==========================================
Files 353 353
Lines 49871 49876 +5
==========================================
+ Hits 31216 31225 +9
+ Misses 15669 15667 -2
+ Partials 2986 2984 -2 ☔ View full report in Codecov by Sentry. |
blakepettersson
requested changes
Dec 11, 2025
Member
blakepettersson
left a comment
There was a problem hiding this comment.
This PR seems to be the exact same one (to the point that there is no diff) of #25565
Author
|
You’re absolutely right, I was unaware of it. Just spent a couple of hours tearing my hair until realizing what the problem was. I’ll close this in favor of #25565 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports the fix in #18133 to fallback to the local Docker config (~/.docker/config.json) in the absence of other credentials.
This should make private OCI repositories like Google's Artifact Registry work via Docker credential helpers like
docker-credential-gcr, allowing authentication to seamlessly happen via workload identity.I believe this is small enough not to need an enhancement proposal, but will happily create one if you disagree!
Checklist: