Skip to content

fix: incorrect source used in CompareAppState#23630

Merged
agaudreault merged 2 commits intoargoproj:masterfrom
agaudreault:fix-sourcediff-compare
Jul 3, 2025
Merged

fix: incorrect source used in CompareAppState#23630
agaudreault merged 2 commits intoargoproj:masterfrom
agaudreault:fix-sourcediff-compare

Conversation

@agaudreault
Copy link
Copy Markdown
Member

Part of #23356

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault requested a review from a team as a code owner July 1, 2025 21:09
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Jul 1, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.25%. Comparing base (c60a727) to head (49a71b1).
⚠️ Report is 807 commits behind head on master.

Files with missing lines Patch % Lines
controller/state.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23630      +/-   ##
==========================================
+ Coverage   60.23%   60.25%   +0.01%     
==========================================
  Files         345      345              
  Lines       59173    59173              
==========================================
+ Hits        35642    35653      +11     
+ Misses      20658    20647      -11     
  Partials     2873     2873              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agaudreault agaudreault enabled auto-merge (squash) July 1, 2025 22:02
Copy link
Copy Markdown
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good!!

@agaudreault agaudreault merged commit 5c2b13f into argoproj:master Jul 3, 2025
28 checks passed
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jul 9, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants